Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the notion of system_install by system_service #96

Closed
s0undt3ch opened this issue Feb 1, 2022 · 0 comments · Fixed by #134
Closed

Replace the notion of system_install by system_service #96

s0undt3ch opened this issue Feb 1, 2022 · 0 comments · Fixed by #134

Comments

@s0undt3ch
Copy link
Contributor

This is to make it more explicit on what the variable does.

Also, the variable should be not be set on the salt factories manager, it should be set on the daemons.
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 12, 2022
@s0undt3ch
Renamed all occurrences of system_install to system_service.
028cbe4 
Renamed the ``system_install`` configuration flag, markers and behaviours when set to ``system_service`` to better reflect what it's actually used for.

Fixes saltstack#96

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 13, 2022
@s0undt3ch
Renamed all occurrences of system_install to system_service.
49f1145 
Renamed the ``system_install`` configuration flag, markers and behaviours when set to ``system_service`` to better reflect what it's actually used for.

Fixes saltstack#96

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch mentioned this issue Jul 13, 2022
Merged
s0undt3ch added a commit that referenced this issue Jul 14, 2022
@s0undt3ch
Renamed all occurrences of system_install to system_service.
2510594 
Renamed the ``system_install`` configuration flag, markers and behaviours when set to ``system_service`` to better reflect what it's actually used for.

Fixes #96

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several improvements required to test salt against artifact packages s0undt3ch/pytest-salt-factories
1 participant
@s0undt3ch