Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The container implementation should be sensible to the exited state when starting the container #165

Closed
s0undt3ch opened this issue Sep 20, 2023 · 0 comments · Fixed by #166
Closed

The container implementation should be sensible to the exited state when starting the container #165

s0undt3ch opened this issue Sep 20, 2023 · 0 comments · Fixed by #166

Comments

@s0undt3ch
Copy link
Contributor

If a container exits immediately, salt-factories continues to check for the running state and ignores the exited state which means it will use all of the timeout available, for all of the available attempts as opposed to exiting immediately.
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Sep 20, 2023
@s0undt3ch
The container implementation is now sensible to the exited st…
ee5de84 
…ate.

Fixes saltstack#165

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch mentioned this issue Sep 20, 2023
Merged
s0undt3ch added a commit that referenced this issue Sep 20, 2023
@s0undt3ch
The container implementation is now sensible to the exited st…
838e651 
…ate.

Fixes #165

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The container implementation is now sensible to the exited state. s0undt3ch/pytest-salt-factories
1 participant
@s0undt3ch