Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default timeout not used #117

Closed
s0undt3ch opened this issue Apr 19, 2022 · 0 comments
Closed

Default timeout not used #117

s0undt3ch opened this issue Apr 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@s0undt3ch
Copy link
Contributor

s0undt3ch commented Apr 19, 2022 •
edited
Loading

When there's a timeout key defined in the configuration, or when timeout is passed to the CLI factory contructor, namely for CLI scripts, the --timeout flag is not added to the generated cmdline.
@s0undt3ch s0undt3ch added the bug Something isn't working label Apr 19, 2022
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Apr 19, 2022
@s0undt3ch
Fix passing default timeout to CLI factories.
5bf7f88 
``--timeout`` is now correctly passed for CLI factories when either ``timeout`` is defined on the configuration or when ``timeout`` is passed to the CLI factory constructor.

Fixes saltstack#117

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s0undt3ch