-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(kitchen): use pre-salted images instead #92
ci(kitchen): use pre-salted images instead #92
Conversation
@myii , fixed the scripts, added the missing deps and uploaded new images. I left here cleaned up Regarding But when the packer scripts are ready to build working images, I don't see why not to build the 'complete' matrix (os * os_version * salt_version * python_version) that 'makes sense'? We can discuss this in the irc/slack channels, wdyt? |
@javierbertoli Great work! So it should be pulling the new images automatically, right? Nothing else needs configuring here, does it?
The link you've provided ends in a
Oh dear, Travis isn't going to like you! But that sounds very interesting indeed. Look forward to these discussions. |
Sorry, the correct link is to the gist is https://gist.github.com/javierbertoli/2475fb8ba1ffeffcde62226357694e7a |
6d9dbfb
to
2855ed6
Compare
Much cleaner implementation in the gist so I've used that as the commit instead, authored by @javierbertoli. Just going to confirm that the final tests are successful and then I'll merge this. |
LGTM :) |
One remark (the same as before I think): how to we industrialize creation of images? Are those run on travis? Is the code to generate them available in the saltstack github org? ... |
@daks I may be wrong but I believe @javierbertoli intends to share the scripts and even maybe have these within the organisation itself. |
I found the repo digging in slack backlog https://github.com/netmanagers/salt-image-builder/blob/master/salt-testing-docker.json :) |
Good work @javierbertoli and thanks for the review and merge @daks! |
🎉 This PR is included in version 2.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@javierbertoli has prepared pre-salted images, which run much faster. This
WIP
PR implements these for CI testing instead.udev
installations fromprovision_command
once the images have that installed.centos-6
.