Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(kitchen): use pre-salted images instead #92

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

myii
Copy link
Member

@myii myii commented Apr 23, 2019

@javierbertoli has prepared pre-salted images, which run much faster. This WIP PR implements these for CI testing instead.


  • Confirm this implementation is OK -- updated from @javierbertoli's gist linked below.
  • Remove all udev installations from provision_command once the images have that installed.
  • Decide what to do about centos-6.

@javierbertoli
Copy link
Member

@myii , fixed the scripts, added the missing deps and uploaded new images.

I left here cleaned up kitchen.yml and .travis.yml files, merging what you did here and what I was prepraring. I tested them locally and they 'work for me' (TM) 😋

Regarding centos-6, as I was building locally, I cannot test it due to the vsyscall issue.

But when the packer scripts are ready to build working images, I don't see why not to build the 'complete' matrix (os * os_version * salt_version * python_version) that 'makes sense'? We can discuss this in the irc/slack channels, wdyt?

@myii
Copy link
Member Author

myii commented Apr 23, 2019

@myii , fixed the scripts, added the missing deps and uploaded new images.

@javierbertoli Great work! So it should be pulling the new images automatically, right? Nothing else needs configuring here, does it?

I left here cleaned up kitchen.yml and .travis.yml files, merging what you did here and what I was prepraring. I tested them locally and they 'work for me' (TM) yum

The link you've provided ends in a 404 -- do you have an updated link?

Regarding centos-6, as I was building locally, I cannot test it due to the vsyscall issue.

But when the packer scripts are ready to build working images, I don't see why not to build the 'complete' matrix (os * os_version * salt_version * python_version) that 'makes sense'? We can discuss this in the irc/slack channels, wdyt?

Oh dear, Travis isn't going to like you! But that sounds very interesting indeed. Look forward to these discussions.

@javierbertoli
Copy link
Member

Sorry, the correct link is to the gist is https://gist.github.com/javierbertoli/2475fb8ba1ffeffcde62226357694e7a

@myii myii force-pushed the chore/use-salted-ci-images branch from 6d9dbfb to 2855ed6 Compare April 23, 2019 11:38
@myii myii changed the title WIP: ci(kitchen): use pre-salted images instead ci(kitchen): use pre-salted images instead Apr 23, 2019
@myii
Copy link
Member Author

myii commented Apr 23, 2019

Much cleaner implementation in the gist so I've used that as the commit instead, authored by @javierbertoli. Just going to confirm that the final tests are successful and then I'll merge this.

@daks
Copy link
Member

daks commented Apr 23, 2019

LGTM :)

@daks
Copy link
Member

daks commented Apr 23, 2019

One remark (the same as before I think): how to we industrialize creation of images? Are those run on travis? Is the code to generate them available in the saltstack github org? ...

@myii
Copy link
Member Author

myii commented Apr 23, 2019

@daks I may be wrong but I believe @javierbertoli intends to share the scripts and even maybe have these within the organisation itself.

@daks
Copy link
Member

daks commented Apr 23, 2019

I found the repo digging in slack backlog https://github.com/netmanagers/salt-image-builder/blob/master/salt-testing-docker.json :)

@daks daks merged commit a741a47 into saltstack-formulas:master Apr 23, 2019
@myii myii deleted the chore/use-salted-ci-images branch April 23, 2019 13:12
@myii
Copy link
Member Author

myii commented Apr 23, 2019

Good work @javierbertoli and thanks for the review and merge @daks!

@saltstack-formulas-travis

🎉 This PR is included in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants