Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tpldir): use tpldir or derivatives to make formula portable #46

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

myii
Copy link
Member

@myii myii commented Feb 24, 2019


Adapted from the introduction in 068a94d (#28):

{%- set topdir = tpldir.split('/')[0] %}

@myii
Copy link
Member Author

myii commented Feb 24, 2019

@vutny I'm particularly interested in applying this workaround/fix to the remaining files in postgres-formula, since most of that formula has been made portable. What do you think?

@myii myii force-pushed the PR_make-formula-portable branch from 03c71f4 to 52d03d8 Compare February 24, 2019 05:30
@myii
Copy link
Member Author

myii commented Feb 24, 2019

@aboe76 Thanks for the review. Do you mind merging it? Hopefully, @vutny and I can have the conversation over at the postgres-formula.

@aboe76 aboe76 merged commit 48b43d0 into saltstack-formulas:master Feb 24, 2019
@aboe76
Copy link
Member

aboe76 commented Feb 24, 2019

@myii merged it

@myii
Copy link
Member Author

myii commented Feb 24, 2019 via email

@myii myii deleted the PR_make-formula-portable branch February 24, 2019 17:23
@saltstack-formulas-travis

🎉 This PR is included in version 0.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants