Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementing semantic release #51

Merged
merged 1 commit into from
May 29, 2019
Merged

feat: implementing semantic release #51

merged 1 commit into from
May 29, 2019

Conversation

daks
Copy link
Member

@daks daks commented May 29, 2019

Continuing work on this formula.

@daks daks force-pushed the semantic-release branch from a111ea1 to 8857021 Compare May 29, 2019 11:34
myii
myii requested changes May 29, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daks Just a few minor changes, thanks. Outside of these files, could you also include:

  1. bin/kitchen -- necessary, since the documentation says we're going to provide it!
  2. The three-line header in pillar.example -- this one isn't important.

docs/CONTRIBUTING.rst
BREAKING CHANGE: With the removal of all of the `.sls` files under
`template package`, this formula no longer supports the installation of
packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove everything below this line.

docs/TOFS_pattern.rst Outdated Show resolved Hide resolved
FORMULA
release: 1
minimum_version: 2016.11
summary: Sudoers formula
description: Formula to configure sudo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudoers perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the program is named sudo :) I don't know why the formula is named that way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README doesn't help us here:

Set up sudo and the sudoers included files.

So it does both! Since there's confusion, maybe it's best to stick to sudoers, for consistency.

Copy link
Member Author

@daks daks May 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except that "sudoers" doesn't mean anything, the program is sudo, the package is sudo, this is the name you find everywhere, see https://packages.debian.org/search?keywords=sudo&searchon=names&suite=stable&section=all for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the problem is, every reference in the formula is for sudoers... the name of the formula, the directory structure, the pillar, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or why don't we just write both, just like the README? Meaning:

Suggested change
description: Formula to configure sudo
description: Formula to configure sudo and the sudoers included files

Or something like that.

FORMULA Outdated Show resolved Hide resolved
@daks
Copy link
Member Author

daks commented May 29, 2019 •
edited
Loading

@daks Just a few minor changes, thanks. Outside of these files, could you also include:

1. `bin/kitchen` -- necessary, since the documentation says we're going to provide it!

I just realize that we want to include bin/kitchen (see saltstack-formulas/template-formula#112) I thought we wanted to generate it at every test.
Sound weird, cc @n-rodriguez

update: done

@daks daks force-pushed the semantic-release branch from 8857021 to b8f75c1 Compare May 29, 2019 15:32
@daks daks force-pushed the semantic-release branch from b8f75c1 to 1a59d4e Compare May 29, 2019 15:42
@daks
Copy link
Member Author

daks commented May 29, 2019

One last push. I hope everything is OK. I may not be able to work on it before next week.

@myii
Copy link
Member

myii commented May 29, 2019

Just this requested change missing: #51 (comment).

@myii myii mentioned this pull request May 29, 2019
Open
71 tasks
@myii myii merged commit 4fb086a into saltstack-formulas:master May 29, 2019
@myii
Copy link
Member

myii commented May 29, 2019

@daks Merged, I'll submit the minor changes in a subsequent PR. Thanks again!

myii added a commit to myii/sudoers-formula that referenced this pull request May 29, 2019
@myii
docs: fix CONTRIBUTING and README
d604876 
* Finalises comments from saltstack-formulas#51
@myii myii mentioned this pull request May 29, 2019
Merged
saltstack-formulas-travis pushed a commit that referenced this pull request May 29, 2019
@semantic-release-bot
chore(release): 0.21.0 [skip ci]
09bbb6f 
# [0.21.0](v0.20.0...v0.21.0) (2019-05-29)

### Documentation

* fix `CONTRIBUTING` and `README` ([d604876](d604876)), closes [#51](#51)

### Features

* implementing semantic release ([1a59d4e](1a59d4e))
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daks @myii @saltstack-formulas-travis