test: merge all test suites into a single (default) suite

[myii]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

• test(pillar): use static test/salt/pillar/top.sls template-formula#238
  • This was the source of using pillars_from_directories & test/salt/pillar/top.sls.
• Semi-automated using feat(salt): merge all test suites into single suite (using pillars_from_directories, test/salt/pillar/top.sls and platforms.verifier.inputs) myii/ssf-formula#384
  • Configures pillars_from_directories, test/salt/pillar/top.sls and kitchen.platforms.verifier.inputs.

Describe the changes you're proposing

Many formulas have more test suites than they actually require. In most cases, the test suites are near identical and are only split up because of minor differences in the pillar/config provided to the CI. This becomes inconvenient when there are numerous map.jinja verification files that need to be updated when new PRs are submitted.

In this PR, the only difference between the suites was based upon the version number of Salt that is used for verifying the correct version of Salt is installed by the formula. This is now handled by providing the Salt version using Chef InSpec Inputs, which is now also handled by the ssf-formula.

Rolling this out before pushing out the new pre-salted images for 3004, which would end up resulting in another near-duplicate test suite being created otherwise.

Pillar / config required to test the proposed changes

As used by the CI.

Debug log showing how the proposed changes work

As seen in the CI.

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

[myii]

Self-merging since this doesn't touch the formula in any way, only re-organises the tests and CI.

The Vagrant-based failing tests are based upon 429 errors, which happen from time to time. The jobs in my fork that ran alongside this PR actually passed (for the ones that failed here):

• https://github.com/saltstack-formulas/salt-formula/runs/4244498912?check_suite_focus=true
• https://github.com/myii/salt-formula/runs/4244491285?check_suite_focus=true

The Proxy-based testing on Windows will need more investigation, since they are unrelated to the changes in this PR. @dafyddj, would you care to take a look?

• https://github.com/saltstack-formulas/salt-formula/actions/runs/1473899131

[saltstack-formulas-travis]

🎉 This PR is included in version 1.9.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀