Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recursive management of minion.d and master.d. #51

Merged
merged 1 commit into from
Oct 6, 2014

Conversation

andrew-vant
Copy link
Contributor

This allows users to easily add configuration settings that the formula doesn't yet provide, without having to modify the existing templates. They do this by putting them in an extra file under salt/files/master.d or minion.d.

In my case I wanted to be able to set Mine settings, which aren't in the templates. I could easily see someone else needing it; for example, because of a gap between a master or minion setting being added to Salt, and the same setting being added to this formula.

The underscore in the new file name is there because salt appears to load the .d directories alphabetically with later files overriding earlier ones. This way, settings in user-created files will override the ones we provide (although they should really be using pillar if they want to do that, so in theory it shouldn't be an issue).

Clean recurse seems like the right thing to me here, but I'm not 100% sure of that. Opinion?

This allows users to easily add configuration settings that the formula
doesn't yet provide, without having to modify the existing templates.
@gravyboat
Copy link
Contributor

I like this, it means that we're way more flexible when it comes to a bunch of files in the directory. Regarding the clean recurse, it seems like that would pretty much be required.

gravyboat added a commit that referenced this pull request Oct 6, 2014
Added recursive management of minion.d and master.d.
@gravyboat gravyboat merged commit 05087a8 into saltstack-formulas:master Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants