Allow disabling services or just ignoring them. #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboe76
reviewed
Feb 20, 2020
|
Hi, just a comment that commit messages in this project must follow a particular format. |
|
@dafyddj any advice on how to proceed now? i.e. I already have the branch and N commits. |
|
Are you familiar with Git's interactive rebase? Alternatively a maintainer could do it for you prior to merge. |
Instead of the default service.running + enabled, you can control the actual state, via pillar. And you can even say 'state = ignore' and no state will be generated to control the service
cr1st1p
force-pushed
the
allow-disable-services
branch
from
1a567a0 to
29ffd68
Compare
|
thank you @dafyddj for the help! |
aboe76
approved these changes
Feb 20, 2020
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
It allows for minion, master, and salt-api to either ignore the state of the service or instead of enabling it, to disable it.
Pillar / config required to test the proposed changes
Check the defaults file, and play with the keys
(master|minion|api).service.(ignore,enabled).
The reason behind these flags:
Reason: installing salt-master and salt-api inside a docker image, and in there I do not have systemd running (and current code also wrongly tries to use 'upstart' in an ubuntu container...)
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context