Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file external_auth special directives #381

Merged

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Aug 6, 2018

No description provided.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias
Copy link
Contributor Author

kyrias commented Aug 6, 2018

Hmm, this gets even more complicated when trying to support specific modules and arguments to those modules. Must be some nicer way to write this, hum.

Copy link
Member

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. First time I have seen startswith being used in Jinja!!

@aboe76 aboe76 merged commit 3888519 into saltstack-formulas:master Dec 19, 2018
@kyrias kyrias deleted the external_auth-file-directives branch December 20, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants