[Minion] [returner] [Elasticsearch] Yaml read patch + example.pillar update #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-russell
changed the title
|
@javierbertoli could you also take a look? |
|
Nice improvement. The original documentation in SaltStack for this returner definitely could be improved, if dot notation is an issue. |
|
@ernstae do you have time to test it, I don't run an elastic server? |
|
It wouldn't be difficult for me to test it. I might not get to it until the weekend, but will fit it in. |
|
@ernstae did you have time to test it? |
ixs
pushed a commit
to bawuenet/salt-formula
that referenced
this pull request
Jul 22, 2018
…update (saltstack-formulas#359) * Minion/returner/elasticsearch yaml read fix. * Improved the documentation for the elasticsearch returner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minion's returner isn't able to read the dot notation, the documentation is less-than-complete
Added whitespace and a parent key 'elasticsearch' to remediate, updated example.pillar