Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for packages version #358

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

iustinam
Copy link
Contributor

@iustinam iustinam commented Feb 1, 2018

  • allow installation of specific packages versions

@iustinam
Copy link
Contributor Author

iustinam commented Feb 1, 2018

Could this feature be added ?

@javierbertoli
Copy link
Member

Seems a useful parameter to add, which will complement #293/#314.

I see there's also a pkg resource in the proxy.sls file, that seems you missed. Can you add that one too?

@iustinam
Copy link
Contributor Author

iustinam commented Feb 1, 2018

@javierbertoli I fail to find that file or any other pkg states referring to salt packages..
Isn't #314 enough? That seems more appropriate since the repo needs to match first..

@javierbertoli
Copy link
Member

@iustinam, re: the proxy.sls file, ignore it. I grep'ed on a dirty local repo, and that file showed. My bad.

Re #314: I think both PRs complement each other: I agree that, usually, #314 will be enough. But that is true only if you use Saltstack's repo and want to pin the repo's version.

But even then, there are a few situations where your PR make sense, ie:

  • You want to use the Saltstack's repo, but you want to pin packages so they're not upgraded without your control
  • You have Saltstack's repo configured, but you want to use another version of the Salt packages, ie, thosse in the distro's repos.
  • You have more than a single distro's repo configured (stable, testing, etc) and want to pin the package version to use.

@aboe76, wdyt? I'm OK with merging this PR.

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aboe76
Copy link
Member

aboe76 commented Feb 1, 2018

@javierbertoli I agree with your logic.

@iustinam
Copy link
Contributor Author

iustinam commented Feb 1, 2018

I just added an example in pillar.example

@javierbertoli javierbertoli merged commit fc20249 into saltstack-formulas:master Feb 1, 2018
@javierbertoli
Copy link
Member

Thanks @iustinam & @aboe76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants