Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for installing pyinotify when using inotify beacons #331

Merged

Conversation

tibold
Copy link
Contributor

@tibold tibold commented Aug 15, 2017

This PR adds support for installing pynotify when inotify beacons are configured on the minion. pyinotify is a required dependency for the inotify beacons to work.

The pyinotify package name is configurable with the salt:lookup:pyinotify pillar value. It will only install the package if the package name is configured and if inotify beacons are used. The default package name is configured for Debian based systems only.

@aboe76
Copy link
Member

aboe76 commented Aug 15, 2017

@tibold could you add archlinux support as well, the package name is: python2-pyinotify

looks good to me @iggy could you take look?

@tibold
Copy link
Contributor Author

tibold commented Aug 16, 2017

@aboe76 yes, of course.

I would be happy to add defaults to all, but I only have access to machines running ubuntu at the moment.

@tibold tibold changed the title Added support for installing pynotify when using inotify beacons Added support for installing pyinotify when using inotify beacons Aug 16, 2017
@aboe76 aboe76 requested a review from iggy August 17, 2017 12:04
Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with adding this

@EvaSDK
Copy link

EvaSDK commented Aug 28, 2017

For Gentoo, the package name is dev-python/pyinotify

@aboe76
Copy link
Member

aboe76 commented Aug 28, 2017

@EvaSDK if I merge this you can create the pull request yourself are you ok with that?

@EvaSDK
Copy link

EvaSDK commented Aug 28, 2017

No problem.

@aboe76 aboe76 merged commit 413a2ea into saltstack-formulas:master Aug 28, 2017
@tibold tibold deleted the fix-inotify-beacon-dependency branch August 29, 2017 10:02
EvaSDK added a commit to EvaSDK/salt-formula that referenced this pull request Sep 11, 2017
aboe76 added a commit that referenced this pull request Sep 11, 2017
Add pyinotify entry for Gentoo, refs #331
nareshov pushed a commit to rocket-labs-sysadmins/salt-formula that referenced this pull request Sep 25, 2017
ixs pushed a commit to bawuenet/salt-formula that referenced this pull request Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants