Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set clean_config_d_dir to False by default #321

Closed
wants to merge 1 commit into from

Conversation

arthurzenika
Copy link
Contributor

@arthurzenika arthurzenika commented Jul 7, 2017

pillar example says :

  # Set this to true to clean any non-salt-formula managed files out of
  # /etc/salt/{master,minion}.d ... You really don't want to do this on 2015.2
  # and up as it'll wipe out important files that Salt relies on.
  clean_config_d_dir: False

This leads me to believe that the default should be False. Am I missing something ?

pillar example says : 

  # Set this to true to clean any non-salt-formula managed files out of
  # /etc/salt/{master,minion}.d ... You really don't want to do this on 2015.2
  # and up as it'll wipe out important files that Salt relies on.
  clean_config_d_dir: False

This leads me to believe that the default should be False. Am I missing something ?
@aboe76
Copy link
Member

aboe76 commented Jul 7, 2017

@arthurlogilab salt will generate some config files in /etc/salt/{master,minion}.d/ that begin with an underscore and these files are excluded in the pattern. so I don't think it is a problem anymore.

https://github.com/saltstack-formulas/salt-formula/blob/master/salt/master.sls#L13
https://github.com/saltstack-formulas/salt-formula/blob/master/salt/minion.sls#L13

found the pr: #111

@aboe76
Copy link
Member

aboe76 commented Jun 8, 2018

@arthurlogilab can we close this one?

@noelmcloughlin
Copy link
Member

Closed as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants