Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new publisher_acl to salt master config #301

Merged
merged 2 commits into from
Apr 8, 2017
Merged

Add new publisher_acl to salt master config #301

merged 2 commits into from
Apr 8, 2017

Conversation

vquie
Copy link
Contributor

@vquie vquie commented Mar 24, 2017

To avoid log flooding with deprecation messages I moved to publisher_acl in salt master config. This PR makes the formula deal with it while it still works with client_acl option.

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vquie
Copy link
Contributor Author

vquie commented Mar 27, 2017

Did some final changes so we always set publisher_acl in salt master config. You can still use client_acl in your pillar though.

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, see no issues so far

@aboe76
Copy link
Member

aboe76 commented Mar 28, 2017

@iggy could you take a look too?

@aboe76
Copy link
Member

aboe76 commented Apr 7, 2017

@tampakrap or @puneetk can any of you review this too, so we can merge this

@aboe76 aboe76 merged commit 03ec0dc into saltstack-formulas:master Apr 8, 2017
@aboe76
Copy link
Member

aboe76 commented Apr 8, 2017

thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants