Use repo.saltstack.com in salt.pkgrepo for Debian-based distributions #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My only doubt is wheter the "osmajorrelease" grain has a correct value on Ubuntu (i.e. something like "16.04"). I don't have any Ubuntu host to check this. |
9 tasks
repo.saltstack.com handles all currently supported Debian releases as well as all supported Ubuntu releases so this change should be fine. Part of saltstack-formulas#180.
|
After having asked on IRC, I got confirmation that "osmajorrelease" is not available on Ubuntu. So I fixed my commit to fallback to "osrelease" when "osmajorrelease" is not available. I believe it's now safe to be merged. |
|
Anyone willing to review and merge? If nobody steps up in the next few days, I'll merge my own work. |
|
Looks good to me, sorry for missing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo.saltstack.com handles all currently supported Debian releases as well
as all supported Ubuntu releases so this change should be fine.
Part of #180.