Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded paths with {{ slspath }} variable #143

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Remove hardcoded paths with {{ slspath }} variable #143

merged 1 commit into from
Jun 9, 2015

Conversation

aboe76
Copy link
Member

@aboe76 aboe76 commented Jun 9, 2015

Please test this, it works on 2015.5.x but {{ slspath }} isn't available on 2014.1 and below,

see also this issue : saltstack/salt#4348

puneetk added a commit that referenced this pull request Jun 9, 2015
Remove hardcoded paths with {{ slspath }} variable
@puneetk puneetk merged commit 975dd08 into saltstack-formulas:master Jun 9, 2015
@aneeshusa
Copy link

Heads up, apparently slspath is not recommended and we should be using tpldir instead; see further discussion in the issue linked above.

@puneetk
Copy link
Contributor

puneetk commented Jun 10, 2015

Sounds good @aneeshusa , whenever the issue saltstack/salt#4348 is released, send over a pull request with the change to tpldir, and updated documentation to reflect that the formula is now 2015 only.

@iggy
Copy link
Contributor

iggy commented Jun 11, 2015

Despite what Rallytime says in that bug report, SaltStack appears to still be doing 2014.7 releases (the last one was less than a month ago). I think it won't kill us to keep support for $current-1 releases.

@aneeshusa
Copy link

@iggy, that's why I asked, and I feel the same way: $current-1 still seems to be somewhat supported, regardless of what they say. (Also, I don't know about the enterprise support options, but having 0 overlap in support windows when a new version comes out seems strange to me.)

slspath is supported in 2014.7 and up, but tpldir is only available in 2015.5 and up, so I think we may want to close this out and open a new issue up to switch to tpldir when 2015.5 becomes $current-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants