Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion in api.service #112

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Fix recursion in api.service #112

merged 1 commit into from
Mar 29, 2015

Conversation

aboe76
Copy link
Member

@aboe76 aboe76 commented Mar 28, 2015

fix recursion in formula depency should be on master service.

@iggy
Copy link
Contributor

iggy commented Mar 29, 2015

I think the better fix is to change the default.yaml file to make api_service point to salt-master instead of salt-api. It should only be salt-api on ancient versions of Salt (where salt-api was a separate process).

@iggy
Copy link
Contributor

iggy commented Mar 29, 2015

Hmm, you'd still have to handle the ancient case where api_service was legitimately salt-api. You'd still end up looping. I guess your fix is probably the most right (or least incorrect anyway) :/

@aboe76
Copy link
Member Author

aboe76 commented Mar 29, 2015

@iggy I don't thinks so.

Even with the latest salt from develop I need to start salt-api.service to open port 8000 even though I have the rest_cherrypy config in place.

By default the salt-api isn't started with the salt-master process....but it needs the salt-master process to connect and configure it.

nmadhok added a commit that referenced this pull request Mar 29, 2015
@nmadhok nmadhok merged commit 74d9ce2 into saltstack-formulas:master Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants