Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor map.jinja + style changes #11

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

daks
Copy link
Member

@daks daks commented Jul 18, 2022

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

N/A

Describe the changes you're proposing

Switch to latest version of map.jinja from template-formula.
Also reformat *.sls files to use two spaces for indentation and uniformize template files headers

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@daks daks force-pushed the map.jinja branch 7 times, most recently from 0c2c7a0 to 0869959 Compare July 18, 2022 13:26
@daks daks changed the title chore: refacto map.jinja chore: refacto map.jinja + style changes Jul 18, 2022
@daks daks marked this pull request as ready for review July 18, 2022 13:29
@daks daks requested review from a team and n-rodriguez as code owners July 18, 2022 13:29
@daks daks requested a review from myii July 18, 2022 13:29
@daks daks changed the title chore: refacto map.jinja + style changes chore: refactor map.jinja + style changes Jul 18, 2022
@daks
Copy link
Member Author

daks commented Jul 29, 2022

by the way, reading this PR by commits is recommended

@daks
Copy link
Member Author

daks commented Aug 30, 2022

merging by myself

@daks daks merged commit 6c0d8b3 into saltstack-formulas:master Aug 30, 2022
@daks daks deleted the map.jinja branch August 30, 2022 15:45
@saltstack-formulas-travis

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants