Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to install Snaps with classic confinement #20

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

ikogan
Copy link

@ikogan ikogan commented Apr 9, 2018

No description provided.

@javierbertoli
Copy link
Member

@ikogan any chance you try to fix the the faliling tests?

A quick peek shows some errors which will problably require something like this

@ikogan ikogan force-pushed the classic-confinement branch from 40f6cef to 8ea508e Compare April 17, 2018 22:41
@ikogan
Copy link
Author

ikogan commented Apr 17, 2018

First, I don't think the errors are reflecting this but the snap used in the example didn't actually exist. That's fixed now.

In terms of the errors, they're happening on master as well and are fairly deep within salt dependencies. I tried for a good while but it looks like there may even be some upstream issues related to this.

Attempting to upgrade Salt creates a different issue, attempting to upgrade pip creates yet another. I'm not quite well versed enough in the Kitchen environment to be able to track this down without a lot more effort than I currently have time for unfortunately.

@javierbertoli javierbertoli merged commit 6947c5a into saltstack-formulas:master Apr 18, 2018
@javierbertoli
Copy link
Member

@ikogan I agree with you. Failures seem to be a totally different issue. I merged this PR and will try to fix tests in another PR.

I appreciate your efforts to try to fix the tests.

@ikogan
Copy link
Author

ikogan commented Apr 18, 2018

Thanks! Sorry I wasn't able to get them fixed, I look forward to seeing what does fix them so I can learn a bit more about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants