feat(semantic-release): implement for this formula #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
myii
force-pushed
the
feat/semantic-release
branch
from
a2dbafa to
c97b956
Compare
|
Included latest changes from saltstack-formulas/template-formula#148. |
daks
approved these changes
Jul 10, 2019
myii
force-pushed
the
feat/semantic-release
branch
from
c97b956 to
e670547
Compare
* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148
myii
force-pushed
the
feat/semantic-release
branch
from
e670547 to
1d2e2f5
Compare
|
Now using the new |
|
@myii are you ok with merging? |
|
@aboe76 It's done from my end but @daks raised some concerns in the |
|
@myii I think you are right, merging it. |
|
🎉 This PR is included in version 0.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks @aboe76. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
semantic-release, as we've already done with many other formulas. The functionality has already been tested in my fork. There are a number of issues I've encountered when preparing this PR but I will have to cover them in subsequent comments when I get the opportunity for that. In the meantime, I would like to confirm that we wantsemantic-releaseimplemented for this formula.CC: @javierbertoli @aboe76 @noelmcloughlin @alxwr.