Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic-release): standardise for this formula #79

Merged
merged 3 commits into from
May 14, 2020

Conversation

noelmcloughlin
Copy link
Member

@noelmcloughlin noelmcloughlin commented May 10, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin noelmcloughlin requested a review from a team as a code owner May 10, 2020 02:00
@pull-assistant
Copy link

pull-assistant bot commented May 10, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     feat(semantic-release): standardise for this formula

     fix(script): fix some travis tests

     docs(readme): add depth one

Powered by Pull Assistant. Last update f56ba6a ... 5680c6b. Read the comment docs.

@noelmcloughlin noelmcloughlin force-pushed the refactor branch 3 times, most recently from f1ea04f to fc30c24 Compare May 10, 2020 15:52
@noelmcloughlin
Copy link
Member Author

#80

Copy link
Member

@daks daks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just en eye-ball review but looks fine for me

@noelmcloughlin
Copy link
Member Author

Merging. Thanks @daks

I will raise a new PR to fix #60, #70, and #74

@myii
Copy link
Member

myii commented May 14, 2020

@noelmcloughlin Appended commit 8f61ecc after checking this with the ssf-formula. Please note the changes.

We've also prepared the 3000.3 images. Please do not update your PRs, since it will be much easier for me to propagate these changes automatically. Just giving you a heads up that this will be happening soon. Feel free to use the new images for new PRs, though.

@saltstack-formulas-travis

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants