-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(semantic-release): implement an automated changelog #43
docs(semantic-release): implement an automated changelog #43
Conversation
baby-gnu
commented
Jun 21, 2019
- We move the documentation under “docs/”.
- Enable travis “release” stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove docs/_static/css/custom.css, docs/conf.py, docs/index.rst files.
Can you also copy Gemfile
and .gitignore
from template-formula
if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baby-gnu Thanks for this PR. A few changes requested inline and a few more here:
- Please add
bin/kitchen
and include the instructions in theREADME
. - The following files are created automatically so don't need to be added to the PR:
docs/AUTHORS.rst
docs/CHANGELOG.rst
- Not directly related but noticed during the
diff
withtemplate-formula
:- Please add the
os_family
entry to theFORMULA
file. test/integration/default/inspec.yml
-- please update toplatform-name
instead ofos-name
as outlined in test(inspec): readme for default profile and a fix template-formula#141
- Please add the
@baby-gnu Another suggestion: you may want to make this a |
@baby-gnu When you get around to modifying this, could you please update |
Hello @myii, sorry for the delay I was a little bit busy somewhere else.
I can't do that for now since this formula is not yet compatible with python3. My plan (#33) is to avoid changing the formula too much before having a clean minimal test infrastructure and the |
@baby-gnu No problem, let me know when you're ready to merge this. |
710f9f7
to
daa6e97
Compare
* We move the documentation under “docs/”. * Enable travis “release” stage
daa6e97
to
7c81125
Compare
392db5e
to
1210527
Compare
1210527
to
df62ff2
Compare
@baby-gnu Merged, thanks for your contribution. Before merging, I added another commit to do with the headings in the main I also toyed with the idea of adding the new |
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@baby-gnu For your reference, this was one of the passing Travis runs including |
Thanks @aboe76. I should have something new to share soon, to make it easier to manage our 25+ |