Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: follow template-formula guidelines #35

Merged
merged 1 commit into from
Jun 8, 2019
Merged

chore: follow template-formula guidelines #35

merged 1 commit into from
Jun 8, 2019

Conversation

javierbertoli
Copy link
Member

  • Update docs
  • Add auxiliar scripts
  • Add missing headers
  • Update tests and files locations

@javierbertoli javierbertoli requested review from aboe76 and myii June 6, 2019 23:12
@javierbertoli
chore: follow template-formula guidelines
f5dbbf4 
* Update docs
* Add auxiliar scripts
* Add missing headers
* Update tests and files locations
@noelmcloughlin
Copy link
Member

Thanks guys!

@noelmcloughlin noelmcloughlin merged commit 61681c4 into saltstack-formulas:master Jun 8, 2019
@myii myii mentioned this pull request Jun 9, 2019
Open
71 tasks
@myii
Copy link
Member

myii commented Jun 10, 2019

@javierbertoli Just a few points about this, leading to another PR:

  1. Using chore as the commit message type meant that no release was created when this PR was merged, due to chore not bumping the version. We normally use feat for all semantic-release PRs, so I'd suggest another PR with a simple feat commit to help make the release.
  2. While I understand the shortening of platform names in kitchen.yml, I would recommend sticking to the same names that are used in template-formula and all of the other formulas. The main reason for this is to make it easier to propagate changes across formulas; it becomes much harder to work with diffs when more and more things are different.
  3. In fact, while it's not particularly pleasant, I also prefer leaving all of the rest of the instances commented out in .travis.yml, just to aid the diff process.

Out of the three things listed above, I reckon the first two are worth putting in a new PR. What are your thoughts?

javierbertoli added a commit to netmanagers/iptables-formula that referenced this pull request Jun 11, 2019
@javierbertoli
feat: semver-release
32a7ba6 
implement [suggested changes](saltstack-formulas#35 (comment)),
to improve consistency across formulas
@javierbertoli javierbertoli mentioned this pull request Jun 11, 2019
Merged
saltstack-formulas-travis pushed a commit that referenced this pull request Jun 11, 2019
@semantic-release-bot
chore(release): 0.14.0 [skip ci]
f6ff6bd 
# [0.14.0](v0.13.0...v0.14.0) (2019-06-11)

### Features

* semver-release ([32a7ba6](32a7ba6)), closes [/github.com//pull/35#issuecomment-500583112](https://github.com//github.com/saltstack-formulas/iptables-formula/pull/35/issues/issuecomment-500583112)
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboe76 aboe76 aboe76 approved these changes

@myii myii Awaiting requested review from myii

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javierbertoli @noelmcloughlin @myii @saltstack-formulas-travis @aboe76