Migrate to and align with template-formula format #20

noelmcloughlin · 2019-06-15T01:47:56Z

This PR migrates golang-formula to template-formula.
Many iterations of testing and refactoring was done. Result verified on Ubuntu 18 and CentOS7

golang.clean

----------
          ID: golang-cli-package-archive-clean-file-absent
    Function: file.absent
        Name: /usr/local/go1.10.1.linux-amd64
      Result: True
     Comment: File /usr/local/go1.10.1.linux-amd64 is not present
     Started: 18:34:06.271489
    Duration: 0.26 ms
     Changes:   
----------
          ID: golang-cli-package-archive-clean-file-absent
    Function: file.absent
        Name: /usr/local/go1.10.1.linux-amd64/go
      Result: True
     Comment: File /usr/local/go1.10.1.linux-amd64/go is not present
     Started: 18:34:06.271840
    Duration: 0.19 ms
     Changes:   
----------
          ID: golang-package-archive-remove-home-alternative-remove
    Function: alternatives.remove
        Name: golang-home
      Result: True
     Comment: onlyif condition is false
     Started: 18:34:06.272687
    Duration: 1234.989 ms
     Changes:   
----------
          ID: golang-package-archive-remove-go-alternative-remove
    Function: alternatives.remove
        Name: link-go
      Result: True
     Comment: onlyif condition is false
     Started: 18:34:07.508041
    Duration: 14.588 ms
     Changes:   
----------
          ID: golang-package-archive-remove-godoc-alternative-remove
    Function: alternatives.remove
        Name: link-godoc
      Result: True
     Comment: onlyif condition is false
     Started: 18:34:07.523034
    Duration: 13.753 ms
     Changes:   
----------
          ID: golang-package-archive-remove-gofmt-alternative-remove
    Function: alternatives.remove
        Name: link-gofmt
      Result: True
     Comment: onlyif condition is false
     Started: 18:34:07.537215
    Duration: 15.506 ms
     Changes:   
----------
          ID: golang-config-clean-file-absent
    Function: file.absent
        Name: /etc/golang
      Result: True
     Comment: File /etc/golang is not present
     Started: 18:34:07.553068
    Duration: 0.478 ms
     Changes:   
----------
          ID: golang-config-clean-file-absent
    Function: file.absent
        Name: /etc/default/golang.sh
      Result: True
     Comment: File /etc/default/golang.sh is not present
     Started: 18:34:07.553749
    Duration: 0.323 ms
     Changes:   

Summary for local
------------
Succeeded: 8
Failed:    0
------------
Total states run:     8
Total run time:   1.280 s

golang

          ID: golang-package-archive-install-file-directory
    Function: file.directory
        Name: /usr/local/go1.10.1.linux-amd64
      Result: True
     Comment: The directory /usr/local/go1.10.1.linux-amd64 is in the correct state
     Started: 18:37:32.837254
    Duration: 1.272 ms
     Changes:   
----------
          ID: golang-package-archive-install-file-directory
    Function: file.directory
        Name: /usr/local/golang/packages
      Result: True
     Comment: The directory /usr/local/golang/packages is in the correct state
     Started: 18:37:32.838615
    Duration: 1.098 ms
     Changes:   
----------
          ID: golang-package-archive-install-archive-extracted
    Function: archive.extracted
        Name: /usr/local/go1.10.1.linux-amd64
      Result: True
     Comment: https://storage.googleapis.com/golang/go1.10.1.linux-amd64.tar.gz extracted to /usr/local/go1.10.1.linux-amd64/, due to absence of one or more files/dirs
     Started: 18:37:32.840044
    Duration: 8160.77 ms
     Changes:   
              ----------
              extracted_files:
                  - go
                  - go/AUTHORS
                  - go/CONTRIBUTING.md
                  - go/CONTRIBUTORS
                  - go/LICENSE
                  - go/PATENTS
                  - go/README.md
                  - go/VERSION
                  - go/api
                  - go/api/README
                  - go/api/except.txt
                  - go/api/go1.1.txt
                  - go/api/go1.10.txt
                  - go/api/go1.2.txt
                  - go/api/go1.3.txt
                  - go/api/go1.4.txt
                  - go/api/go1.5.txt
                  - go/api/go1.6.txt
                  - go/api/go1.7.txt
                  - go/api/go1.8.txt
                  - go/api/go1.9.txt
                  - go/api/go1.txt
                  - go/api/next.txt
                  - go/bin
                  - go/bin/go
                  - go/bin/godoc
                  - go/bin/gofmt
                  - go/blog
                  - go/blog/content
                  - go/blog/content/4years-gopher.png
                  - go/blog/content/4years-graph.png
                  - go/blog/content/4years.article
                  - go/blog/content/5years
                  - go/blog/content/5years/conferences.jpg
                  - go/blog/content/5years/gophers5th.jpg
                  - go/blog/content/5years.article
                  - go/blog/content/6years-gopher.png
                  - go/blog/content/6years.article
                  - go/blog/content/7years.article
                  - go/blog/content/8years
                  - go/blog/content/8years/image1.png
                  - go/blog/content/8years/image2.png
                  - go/blog/content/8years/image3.png
                  - go/blog/content/8years/image4.png
                  - go/blog/content/8years/photo.jpg
                  - go/blog/content/8years.article
                  - go/blog/content/a-conversation-with-the-go-team.article
                  - go/blog/content/advanced-go-concurrency-patterns.article
                  - go/blog/content/appengine-dec2013.article
                  - go/blog/content/building-stathat-with-go.article
                  - go/blog/content/building-stathat-with-go_stathat_architecture.png
                  - go/blog/content/building-stathat-with-go_weather.png
                  - go/blog/content/c-go-cgo.article
                  - go/blog/content/community-outreach-working-group
                  - go/blog/content/community-outreach-working-group/project.png
                  - go/blog/content/community-outreach-working-group.article
                  - go/blog/content/concurrency-is-not-parallelism.article
                  - go/blog/content/constants
                  - go/blog/content/constants/bool.go
                  - go/blog/content/constants/complex1.go
                  - go/blog/content/constants/complex2.go
                  - go/blog/content/constants/complex3.go
                  - go/blog/content/constants/default1.go
                  - go/blog/content/constants/default2.go
                  - go/blog/content/constants/default3.go
                  - go/blog/content/constants/exercise1.go
                  - go/blog/content/constants/exercise2.go
                  - go/blog/content/constants/exercise3.go
                  - go/blog/content/constants/exercise4.go
                  - go/blog/content/constants/exercise5.go
                  - go/blog/content/constants/exercise6.go
                  - go/blog/content/constants/float1.go
                  - go/blog/content/constants/float2.go
                  - go/blog/content/constants/float3.go
                  - go/blog/content/constants/float4.go
                  - go/blog/content/constants/float5.go
                  - go/blog/content/constants/int1.go
                  - go/blog/content/constants/int2.go
                  - go/blog/content/constants/int3.go
                  - go/blog/content/constants/int4.go
                  - go/blog/content/constants/numbers1.go
                  - go/blog/content/constants/numbers2.go
                  - go/blog/content/constants/string1.go
                  - go/blog/content/constants/string2.go
                  - go/blog/content/constants/string3.go
                  - go/blog/content/constants/string4.go
                  - go/blog/content/constants/syntax.go
                  - go/blog/content/constants.article
                  - go/blog/content/context
                  - go/blog/content/context/google
                  - go/blog/content/context/google/google.go
                  - go/blog/content/context/gorilla
                  - go/blog/content/context/gorilla/gorilla.go
                  - go/blog/content/context/interface.go
                  - go/blog/content/context/server
                  - go/blog/content/context/server/server.go
                  - go/blog/content/context/tomb
                  - go/blog/content/context/tomb/tomb.go
                  - go/blog/content/context/userip
                  - go/blog/content/context/userip/userip.go
----------
          ID: golang-package-archive-install-home-alternative-install
    Function: alternatives.install
        Name: golang-home
      Result: True
     Comment: Alternative for golang-home set to path /usr/local/go1.10.1.linux-amd64/go with priority 4996701
     Started: 18:37:41.001065
    Duration: 83.827 ms
     Changes:   
              ----------
              link:
                  /usr/local/go
              name:
                  golang-home
              path:
                  /usr/local/go1.10.1.linux-amd64/go
              priority:
                  4996701
----------
          ID: golang-package-archive-install-godoc-alternative-install
    Function: alternatives.install
        Name: link-godoc
      Result: True
     Comment: Alternative for link-godoc set to path /usr/local/go1.10.1.linux-amd64/go/bin/godoc with priority 4996701
     Started: 18:37:41.085546
    Duration: 21.016 ms
     Changes:   
              ----------
              link:
                  /usr/bin/godoc
              name:
                  link-godoc
              path:
                  /usr/local/go1.10.1.linux-amd64/go/bin/godoc
              priority:
                  4996701
----------
          ID: golang-package-archive-install-gofmt-alternative-install
    Function: alternatives.install
        Name: link-gofmt
      Result: True
     Comment: Alternative for link-gofmt set to path /usr/local/go1.10.1.linux-amd64/go/bin/gofmt with priority 4996701
     Started: 18:37:41.107011
    Duration: 25.042 ms
     Changes:   
              ----------
              link:
                  /usr/bin/gofmt
              name:
                  link-gofmt
              path:
                  /usr/local/go1.10.1.linux-amd64/go/bin/gofmt
              priority:
                  4996701
----------
          ID: golang-package-archive-install-go-alternative-install
    Function: alternatives.install
        Name: link-go
      Result: True
     Comment: Alternative for link-go set to path /usr/local/go1.10.1.linux-amd64/go/bin/go with priority 4996701
     Started: 18:37:41.132399
    Duration: 24.795 ms
     Changes:   
              ----------
              link:
                  /usr/bin/go
              name:
                  link-go
              path:
                  /usr/local/go1.10.1.linux-amd64/go/bin/go
              priority:
                  4996701
----------
          ID: golang-config-file-managed-environ_file
    Function: file.managed
        Name: /etc/default/golang.sh
      Result: True
     Comment: File /etc/default/golang.sh updated
     Started: 18:37:41.157857
    Duration: 25.643 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0644
----------
          ID: golang-package-archive-install-home-alternative-install
    Function: cmd.run
        Name: update-alternatives --install /usr/local/go golang-home /usr/local/go1.10.1.linux-amd64/go 4996701
      Result: True
     Comment: onlyif condition is false
     Started: 18:37:41.183738
    Duration: 0.416 ms
     Changes:   
----------
          ID: golang-package-archive-install-home-alternative-set
    Function: alternatives.set
        Name: golang-home
      Result: True
     Comment: Alternative for golang-home already set to /usr/local/go1.10.1.linux-amd64/go
     Started: 18:37:41.184332
    Duration: 4.09 ms
     Changes:   
----------
          ID: golang-package-archive-install-go-alternative-install
    Function: cmd.run
        Name: update-alternatives --install /usr/bin/go link-go /usr/local/go1.10.1.linux-amd64/go/bin/go 4996701
      Result: True
     Comment: onlyif condition is false
     Started: 18:37:41.188599
    Duration: 0.378 ms
     Changes:   
----------
          ID: golang-package-archive-install-go-alternative-set
    Function: alternatives.set
        Name: link-go
      Result: True
     Comment: Alternative for link-go already set to /usr/local/go1.10.1.linux-amd64/go/bin/go
     Started: 18:37:41.189416
    Duration: 4.044 ms
     Changes:   
----------
          ID: golang-package-archive-install-godoc-alternative-install
    Function: cmd.run
        Name: update-alternatives --install /usr/bin/godoc link-godoc /usr/local/go1.10.1.linux-amd64/go/bin/godoc 4996701
      Result: True
     Comment: onlyif condition is false
     Started: 18:37:41.193638
    Duration: 0.379 ms
     Changes:   
----------
          ID: golang-package-archive-install-godoc-alternative-set
    Function: alternatives.set
        Name: link-godoc
      Result: True
     Comment: Alternative for link-godoc already set to /usr/local/go1.10.1.linux-amd64/go/bin/godoc
     Started: 18:37:41.194403
    Duration: 3.85 ms
     Changes:   
----------
          ID: golang-package-archive-install-gofmt-alternative-install
    Function: cmd.run
        Name: update-alternatives --install /usr/bin/gofmt link-gofmt /usr/local/go1.10.1.linux-amd64/go/bin/gofmt 4996701
      Result: True
     Comment: onlyif condition is false
     Started: 18:37:41.198464
    Duration: 0.426 ms
     Changes:   
----------
          ID: golang-package-archive-install-gofmt-alternative-set
    Function: alternatives.set
        Name: link-gofmt
      Result: True
     Comment: Alternative for link-gofmt already set to /usr/local/go1.10.1.linux-amd64/go/bin/gofmt
     Started: 18:37:41.199346
    Duration: 3.77 ms
     Changes:   

Summary for local
-------------
Succeeded: 16 (changed=6)
Failed:     0
-------------
Total states run:     16
Total run time:    8.361 s

noelmcloughlin · 2019-06-15T23:47:55Z

Upstream error causing failed travis jobs: saltstack/salt#44980 (comment)

noelmcloughlin · 2019-06-16T01:05:49Z

Implementation mirrors prometheus PR saltstack-formulas/prometheus-formula#5

…-formula into new_formula

noelmcloughlin · 2019-06-16T23:12:42Z

Upstream error causing failed travis jobs: saltstack/salt#44980 (comment)

Still an issue.

noelmcloughlin · 2019-06-23T15:50:23Z

Travis fails due to upstream salt issue: 'pip.installed' is not available when running highstate saltstack/salt#44980 (comment)
Well tested manually - this PR is too big to review probably.
follow up PRs can address any issues.
Merging per "if your pull request has stayed open for more than a couple days feel free to "selfie-merge" your own." @ community critiera

* Completes saltstack-formulas#20

saltstack-formulas-travis · 2019-06-25T16:17:38Z

🎉 This PR is included in version 0.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [0.3.2](v0.3.1...v0.3.2) (2019-06-28) ### Bug Fixes * **`semantic-release`:** finalise changes from `template-formula` ([a38392d](a38392d)), closes [#20](#20)

noelmcloughlin added 4 commits June 15, 2019 02:31

refactor(formula): convert to follow template-formula

80b4352

fix(cleanup): check for alternative before calling remove

ad5a911

Fix typo

2d7c03f

fix(clean): check for alternative before calling remove

3b75421

noelmcloughlin force-pushed the new_formula branch from d300ddd to 3b75421 Compare June 15, 2019 12:24

fix(init): remove rebase comment

c76d7cd

noelmcloughlin force-pushed the new_formula branch from 04187c1 to c76d7cd Compare June 15, 2019 18:58

test(inspec): add golang archive unittests

6feafa9

noelmcloughlin mentioned this pull request Jun 16, 2019

feat(archives): tarball archives & linux alternatives saltstack-formulas/prometheus-formula#5

Merged

noelmcloughlin force-pushed the new_formula branch 16 times, most recently from 3a4bac4 to a21db40 Compare June 16, 2019 13:21

fix(source_hash): remove unused 'source_hash' consant

a12c5f7

noelmcloughlin force-pushed the new_formula branch from a21db40 to a12c5f7 Compare June 16, 2019 13:54

noelmcloughlin requested a review from aboe76 June 16, 2019 23:00

noelmcloughlin requested review from baby-gnu, daks, javierbertoli and myii June 16, 2019 23:00

Merge branch 'master' of https://github.com/saltstack-formulas/golang…

3bd6a83

…-formula into new_formula

noelmcloughlin removed request for daks, javierbertoli, baby-gnu, aboe76 and myii June 23, 2019 15:15

test(fixes): fix two kitchen test failures

b01a5d4

noelmcloughlin force-pushed the new_formula branch from 112440d to b01a5d4 Compare June 23, 2019 15:31

noelmcloughlin merged commit ff2b02f into saltstack-formulas:master Jun 23, 2019

noelmcloughlin deleted the new_formula branch June 23, 2019 15:50

noelmcloughlin mentioned this pull request Jun 23, 2019

MacOS group root is not available #19

Closed

myii added a commit to myii/golang-formula that referenced this pull request Jun 25, 2019

fix(semantic-release): finalise changes from template-formula

a38392d

* Completes saltstack-formulas#20

This was referenced Jun 25, 2019

fix(semantic-release): finalise changes from template-formula #21

Merged

Establish template-formula as the go-to resource for all formula development saltstack-formulas/template-formula#21

Open

saltstack-formulas-travis added the released label Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to and align with template-formula format #20

Migrate to and align with template-formula format #20

noelmcloughlin commented Jun 15, 2019 •

edited

Loading

noelmcloughlin commented Jun 15, 2019

noelmcloughlin commented Jun 16, 2019

noelmcloughlin commented Jun 16, 2019

noelmcloughlin commented Jun 23, 2019

saltstack-formulas-travis commented Jun 25, 2019

Migrate to and align with template-formula format #20

Migrate to and align with template-formula format #20

Conversation

noelmcloughlin commented Jun 15, 2019 • edited Loading

noelmcloughlin commented Jun 15, 2019

noelmcloughlin commented Jun 16, 2019

noelmcloughlin commented Jun 16, 2019

noelmcloughlin commented Jun 23, 2019

saltstack-formulas-travis commented Jun 25, 2019

noelmcloughlin commented Jun 15, 2019 •

edited

Loading