[FEATURE] Permit to install files from salt fileserver instead of getting content in pillar

[baby-gnu]

Is your feature request related to a problem?

I need to tweak my exim configure to:

• use a smarthost with authentication
• force the connection to be SMTPS (it does not support STARTTLS)

I need to:

1. Create /etc/exim4/exim4.conf.localmacros with proper macro definitions
2. Create /etc/exim4/passwd.client

Describe the solution you'd like

I think that the current handling of extra configuration files could be extended or modified to lookup files as template from the salt fileserver instead of the pillar.

As an example of what I'm thinking:

{%- set extra_files = salt['config.get']('exim:extra_files')
{%- if extra_files %}
{%-   for filename, params in extra_files.items() %}
{#-     Use filename as default source name %}
{%-     set sources = params.get('sources', [filename])
{%-     set user = params.get('user', 'root') %}
{%-     set group = params.get('group', 'root') %}
{%-     set mode = params.get('mode, '0644') %}
{%-     set template = params.get('template', None)
{%-     set tofs_lookup = 'exim/config/' ~ filename %}
{{ exim.config_dir }}/{{ filename }}:
  file.managed:
    - name: {{ exim.config_dir | path_join(filename) }}
	- source: {{ files_switch(sources, lookup=tofs_lookup) }}
	- user: {{ user }}
	- group: {{ group }}
	- mode: {{ mode }}
	- makedirs: True
{%      if template %}
	- template: jinja
	- context:
	    exim: {{ exim | json }}
{%- endif %}
	- require:
	  - sls: {{ sls_package_install }}
{%-   endfor %}
{%- endif %}

This way I could:

1. Define a pillar like

   exim:
     extra_files:
       exim4.conf.localmacros:
         sources: ['exim4.conf.localmacros.jinja']
    	 template: 'jinja'
       passwd.client:
         sources: [passwd.client.jinja']
    	 user: 'root'
    	 group: 'Debian-exim'
    	 mode: '0640'
    	 template: 'jinja'

2. Put the template files under /exim/files/default/ somewhere in the fileserver files_root.

NB: templating is parameterised because exim configuration file syntax can be seen interpreted as bogus jinja.

Describe alternatives you've considered

I think I could use exim.use_split_config=True and overwrite files under /etc/exim4/conf.d/ but the exim syntax can stay in the way of templating.

Additional context

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[OrangeDog]

The title of this issue is completely different to its content...
Was the feature request in the title ever done?