fix(map.jinja): GPG KEY for EPEL-8 #61
Conversation
itscaro
changed the title
epel/map.jinja
Outdated
| 'key_hash': 'sha256=22f25ad95d5e8d371760815485dba696ea3002fc2c7f812f2c75276853387107', | ||
| 'key_name': 'RPM-GPG-KEY-EPEL-7', | ||
| 'rpm': 'http://download.fedoraproject.org/pub/epel/7/x86_64/Packages/e/epel-release-7-13.noarch.rpm', | ||
| }, | ||
| 8: { | ||
| 'key': 'https://fedoraproject.org/static/352C64E5.txt', | ||
| 'key': 'https://download.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-8', |
There was a problem hiding this comment.
The PR is to correct this GPG key, which is EPEL 7 instead of EPEL 8
epel/map.jinja
Outdated
| 'key': 'https://download.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7', | ||
| 'key_hash': 'sha256=028b9accc59bab1d21f2f3f544df5469910581e728a64fd8c411a725a82300c2', |
There was a problem hiding this comment.
gpg --with-fingerprint 352C64E5.txt
pub 4096R/352C64E5 2013-12-16 Fedora EPEL (7) <epel@fedoraproject.org>
Key fingerprint = 91E9 7D7C 4A5E 96F1 7F3E 888F 6A2F AEA2 352C 64E5
gpg --with-fingerprint RPM-GPG-KEY-EPEL-7
pub 4096R/352C64E5 2013-12-16 Fedora EPEL (7) <epel@fedoraproject.org>
Key fingerprint = 91E9 7D7C 4A5E 96F1 7F3E 888F 6A2F AEA2 352C 64E5
|
Thank you @myii. I had a quick look: The change looks generally good and coincidentally is very similar to what I had locally but forgot to issue a PR for. 🤦🏻♂️ There's just one thing I'd like you to fix before approving. Please change the links from https://download.fedoraproject.org/ to https://dl.fedoraproject.org/. The downloads vhost is serving a redirect to the mirror network. The dl vhost is the canonical master server. For something like the GPG signing key I'd prefer the canonical master without any mirrors in between that might break things in unexpected ways. |
|
Really appreciate the prompt review, @ixs. Excellent feedback, too. |
Signed-off-by: Minh-Quan TRAN <account@itscaro.me>
|
@ixs Thank you for the feedback, I switch to dl.fedoraproject.org :-) Happy holidays! |
|
@itscaro merry christmas or whatever floats your sled. 😂 |
|
A nice, tidy PR -- thanks guys! Merged. |
|
🎉 This PR is included in version 1.15.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The checksum is correct but the url is wrong.
Since I cannot find the key URL in txt format I switch to use the keys from download.fedoraproject.org instead.
Fixes #58
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context