Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement inspec test matrix & semantic-release #17

Merged
merged 3 commits into from
Apr 27, 2019

Conversation

myii
Copy link
Member

@myii myii commented Apr 27, 2019

This PR has been created to be merged before #16. The main purpose is to use inspec tests to help confirm that the changes don't introduce regressions. The secondary benefit achieved is to introduce semantic-release to the formula. All aspects have been tested:

  1. The inspec tests work for the existing formula.
  2. The inspec tests work after Move to New Template #16 has been merged into a temporary test in my own fork.
  3. semantic-release has been tested at the same time as the above.

Fedora had to be disabled for the time being:

systemd[1]: chronyd.service: Refusing to accept PID outside of service control group, acquired through unsafe symlink chain: /var/run/chrony/chronyd.pid

myii added 3 commits April 27, 2019 06:18
* Run `chrony.config` as workaround
  - `.config` not called by `chrony`
* Disable `fedora` for the time being due to `systemd` issue
  - Refusing to accept PID outside of service control group,
    acquired through unsafe symlink chain: /var/run/chrony/chronyd.pid
@myii myii requested a review from daks April 27, 2019 06:01
@myii myii mentioned this pull request Apr 27, 2019
2 tasks
@myii
Copy link
Member Author

myii commented Apr 27, 2019

@javierbertoli Would you have any idea about the Fedora issue mentioned in the comment above?

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @myii is this ready for merging?

@myii
Copy link
Member Author

myii commented Apr 27, 2019

@aboe76 Yes, it's ready to go. Then #16 can be rebased with the required changes.

@myii myii merged commit 13c4f7b into saltstack-formulas:master Apr 27, 2019
@myii myii deleted the chore/add-test-matrix branch April 27, 2019 15:04
@myii
Copy link
Member Author

myii commented Apr 27, 2019

Merged so that #16 can be rebased.

@saltstack-formulas-travis

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants