Update testing environment, attempt to use new formula format #44
Conversation
| - INSTANCE: repositories-debian-9-2019-2-py3 | ||
| - INSTANCE: repositories-ubuntu-1804-2019-2-py3 | ||
| - INSTANCE: preferences-debian-9-2019-2-py3 | ||
| - INSTANCE: preferences-ubuntu-1804-2019-2-py3 |
There was a problem hiding this comment.
Any plan for debian-8 and/or ubuntu-1604?
There was a problem hiding this comment.
Didn't see a valid reason to add them, as the files managed in this formula have not changed in a noticeable way.
kitchen.yml
Outdated
| - apt.repositories | ||
| - apt.update | ||
| pillars_from_files: | ||
| apt.sls: test/integration/repositories/pillar.sls |
There was a problem hiding this comment.
In terms of these pillars_from_files paths (including the one below), goes back to these discussions we had on Slack with @daks:
- https://freenode.logbot.info/saltstack-formulas/20190425#c2137081
- https://freenode.logbot.info/saltstack-formulas/20190425#c2137133 -- you involved in the discussion from here
- Conclusion in
postgres-formulaPR
No way am I suggesting that we should continue with that. But it would be nice to work towards a standard that can be recommended across formulas.
There was a problem hiding this comment.
the idea is to use test/salt/{pillar, states}/ directories to store salt data used for tests
|
A few other points to consider if overhauling this formula (not part of the current changeset). Found these while comparing to the
Can always leave these for another PR. |
|
Nice job @javierbertoli :) |
* Use latest pre-salted images * Move from serverspec to inspec * Fix failing tests
* Use the correct keyring for the OS (a refactor of the changes suggested in saltstack-formulas#41)
* Update docs * Add auxiliar scripts * Add missing headers
|
@javierbertoli Could we do anything to avoid the conflicts with #45, which is the follow-on from #41? |
|
@javierbertoli Thanks for the changes, this is ready to merge for me, except for the decision about the conflict with #45. What's the plan for that? |
I asked @jdkelleher to make a few changes in #45 to make it backward compatible. I think we can merge that one first and then I can fix/update this one. |
|
@javierbertoli OK, so we'll wait for #45 to be updated and merged, then we'll revisit this one. Thanks for accommodating for that. |
myii
changed the title
|
About to merge this but waiting to see what happens with |
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.