map.jinja: use grains.filter_by instead of defaults.merge #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaults.merge does not work with salt-ssh. saltstack/salt#51605
|
@alxwr Thanks for this. I'll get around to reviewing this when I get a bit of time later on. |
|
@alxwr Still not getting time because we're organising major SaltStack Formulas planning in the Slack/IRC/Matrix group. Please join us there if you can make it. The logs are available as well, like I mentioned in the other comment. |
|
@myii Thanks for the invitation, but I'm sorry. I've got to finish some work for a client. |
|
@alxwr Thanks for this; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaults.merge does not work with salt-ssh.
saltstack/salt#51605
Testing