Update towncrier, pylint patch #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renovate should not manage it, at least not minor updates, which can add new checks breaking CI on generated projects. 3.3 adds a new message `too-many-positional-arguments`, which makes sense, but produces a ton of lint warnings on probably all existing modules and can only be fixed by introducing a breaking API change. Let's stay on the 3.2 train for now and consider how to approach the 3.3 update in the future. Options: * Raise the allowed positional arguments to a more reasonable value, then introduce the API change on functions that would have been called via kwargs anyways. * Just disable the message. This is the likely way forward, but I think new projects could benefit from this message, it's just hard to transition existing extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to wait until sphinx-contrib/sphinxcontrib-towncrier#92 is resolved