-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migration files not sorted by timestamp when using glob #1299
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Does this need a test? And if not -> why? |
somehow I was expecting this question :) |
I would need to investigate by jumping into the codebase and spending time into it |
haven't had the capacity to get back to this yet. Still not forgotten though. I consider this a bugfix. |
I originally thought that sorting migration files by their absolute path is good enough. Working with this has painfully taught me otherwise.
So, this changes the sorting of matched files to be done exactly the same way as the non-glob version does it (by the numeric value of the
timestamp
prefix in the filename first - and just locale string compare otherwise (when both timestamps represent the same numeric value).Result is still an array of absolute paths.