Get final batch id from SEPA message #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not look to bad :-) |
ledermann
added a commit
that referenced
this pull request
Feb 19, 2014
Get final batch id from SEPA message
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains changes to provide the batch id of a certain transaction. The batch id is used in bank transactions to reference a certain batch in a SEPA message.
Added are two extra methods for a
SEPA::Message:SEPA::Message#batch_id(transaction_reference): fetches the batch id of the transaction with the given referenceSEPA::Message#batches: returns an array with the batch ids of the batch in the current fileFor a successful implementation of these methods, a refactor was required. Transactions are now stored in groups right after adding a transaction with
add_transaction. For backward compatibility, it is still possible to get all transactions across all batches by calling thetransactionsmethod.