Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove unused file spec/support/active_model.rb #111

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jun 7, 2022

3700e02 added it, to support this gem when Rails 4 was very new.

The gemspec nowadays requires active_model >= 4.2 as a runtime dependency, so this supporting code is never used.

What Rails 4.2 offers:
https://github.com/rails/rails/blob/4-2-stable/activemodel/lib/active_model/model.rb

3700e02 added it.

The project now relies on active_model 4.2 as a runtime dependency, so this code is never used.
@olleolleolle olleolleolle changed the title Remove unused file test: Remove unused file Jun 7, 2022
@olleolleolle olleolleolle changed the title test: Remove unused file test: Remove unused file spec/support/active_model.rb Jun 7, 2022
@ledermann ledermann merged commit 1f9cfa7 into salesking:master Jun 8, 2022
@olleolleolle olleolleolle deleted the patch-1 branch June 8, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants