Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert linux file path to Windows one in WSL #962

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

nrakuyama
Copy link

@nrakuyama nrakuyama commented Feb 22, 2024

What does this PR do?

Make org open command to convert Linux file path to Windows one in WSL.

org open command was changed to open temp html file from to open url directly.
In WSL, the command silently fails because Windows browser tries to open linux file path.

What issues does this PR fix or reference?

forcedotcom/cli#2677
@W-15278875@

@iowillhoit
Copy link
Contributor

Hey @nrakuyama, I do not personally have a way to confirm this is working as expected. From some searching, it looks like wslpath is not a built-in utility, but needs to be installed. What happens with this code if the user does not have wslpath installed? I assume it fails, but does the error message make it clear that the user needs to install the utility?

@nrakuyama
Copy link
Author

Hi, @iowillhoit
wslpath command is bulit into WSL and WSL users don't need to install it.
It was added from Build 17046 which is April 2018 update.
https://learn.microsoft.com/en-us/windows/wsl/release-notes

If wslpath is not installed, command not found error message will appear.
image

@iowillhoit
Copy link
Contributor

Thanks for the confirmation and the screenshot @nrakuyama, I just confirmed that this is still working as expected locally 👍

@iowillhoit iowillhoit merged commit 5a5fe12 into salesforcecli:main Mar 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants