fix: emit sourceApi message, set it on cs, add UTs #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jul 11, 2023
| @@ -350,6 +373,9 @@ const buildRetrieveAndDeleteTargets = async ( | |||
| } else { | |||
| return { | |||
| componentSetFromNonDeletes: await ComponentSetBuilder.build({ | |||
| sourceapiversion: ( | |||
There was a problem hiding this comment.
what happens outside of a project?
test/commands/retrieve/start.test.ts
Outdated
| expect(retrieveStub.firstCall.args[0]).to.deep.equal(expectedRetrieveArgs); | ||
| }; | ||
|
|
||
| // Ensure Lifecycle hooks are called properly |
mshanemc
reviewed
Jul 11, 2023
| const retrieveOpts = await buildRetrieveOptions(flags, format, zipFileName, resolvedTargetDir); | ||
|
|
||
| this.spinner.status = messages.getMessage('spinner.sending'); | ||
|
|
||
| this.retrieveResult = new RetrieveResult({} as MetadataApiRetrieveStatus, componentSetFromNonDeletes); | ||
|
|
||
| if (componentSetFromNonDeletes.size !== 0 || retrieveOpts.packageOptions?.length) { | ||
| // eslint-disable-next-line @typescript-eslint/require-await |
There was a problem hiding this comment.
you could
return Promise.resolve();
at the bottom of the function instead of doing the eslint comment. 🤷🏻
mshanemc
approved these changes
Jul 14, 2023
|
QA notes: before this change (set sourceApiVersion to 56 via with this change✅ (in a project, using source) (top-level, using mdapi) ✅ results are the same for ./bin/dev since it doesn't have project. Importantly, it works without project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds warnings from plugin-source into PDR
adds sourceApiVersion to CS
adds
retrieve startUTs 👀What issues does this PR fix or reference?
forcedotcom/cli#353
@W-13735986@