W-17443248 fix(bulk): fallback columnDelimtier to COMMA
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been linked to a new work item: W-17443248 |
WillieRuemmele
approved these changes
Dec 16, 2024
iowillhoit
changed the title
columnDelimtier to COMMAcolumnDelimtier to COMMA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
detectDelimiterutility to fallback toCOMMAif it can't find the delimiter used in a CSV file:#1110 (comment)
We already do this for
data delete bulk(the CSV is required to be just 1-column of record IDs):plugin-data/src/bulkIngest.ts
Line 74 in 1b02e4a
We set it to
COMMAin the payload but any valid delimiter works, the API defaults toCOMMAif not specified anyway:https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/create_job.htm
What issues does this PR fix or reference?
@W-17443248@