Sm/test double #903
Closed
Sm/test double #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merging.
An experiment with "what if UT need to stub ESM modules?" In this case, it was the new inquirer. (each prompt type is exported as a function. Sinon doesn't handle stubbing those).
there's a lib called testdouble (which looks like it could be a sinon replacement if we were really ambitious).
Alternatives:
re-doing the prompt stuff on sfCommand and using those for a "stubbable seam". That solved inquirer stuff but this sinon-ESM gap is only going to get more severe (using
got, moving some libraries to ESM and wanting to stub something there, etc).