Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow timeouts with --wait #422

Merged
merged 5 commits into from
Apr 17, 2024
Merged

fix: allow timeouts with --wait #422

merged 5 commits into from
Apr 17, 2024

Conversation

WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented Apr 16, 2024

What does this PR do?
will timeout apex tests based on timeout value

What issues does this PR fix or reference?
@W-14364504@
requires: forcedotcom/salesforcedx-apex#364
forcedotcom/cli#2108

Functionality Before
tests would never timeout

Functionality After
tests timeout

@shetzel
Copy link
Contributor

shetzel commented Apr 17, 2024

QA
Used the dreamhouse-lwc project but added 500 tests so that they would take longer than a few minutes to complete.
apex test run -l RunAllTestsInOrg -w 1 - command stops waiting after 1 minute and reports: Run "sf apex get test -i 707... to retrieve test results
apex test run -l RunAllTestsInOrg - command returns immediately and reports: Run "sf apex get test -i 707... to retrieve test results
apex test run -l TestPropertyController -w 5 - command returns after running the test (about 2 seconds) and reports the test results
apex test run -l RunAllTestsInOrg -w 3 - command stops waiting after 3 minutes and reports: Run "sf apex get test -i 707... to retrieve test results

@shetzel shetzel merged commit fcb3467 into main Apr 17, 2024
10 checks passed
@shetzel shetzel deleted the wr/timeoutApex branch April 17, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants