chore: upgrade to latest lwc and @lwc/jest-preset #35
Conversation
jodarove
force-pushed
the
jodarove/upgrade-lwc-and-jest-preset
branch
from
8db03c4 to
dce9e4f
Compare
jodarove
force-pushed
the
jodarove/upgrade-lwc-and-jest-preset
branch
from
b70d7d5 to
404e048
Compare
.circleci/config.yml
Outdated
| @@ -12,6 +12,8 @@ jobs: | |||
| - v1-dependencies-{{ checksum "yarn.lock" }} | |||
| - v1-dependencies- | |||
|
|
|||
| - run: rm -rf node_modules/ | |||
There was a problem hiding this comment.
I noticed this with trim-right dependency (failing CI): in previous versions of @lwc/template-compiler is including @babel/generators (< 7.5, using trim-right) under its node_module dependencies; with the new version, that's not the case, but it was still resolving the old @babel/generators code under the @lwc/template-compiler node_modules.
There was a problem hiding this comment.
Removing the node_modules defeats the purpose of using cache. I would instead bump the cache version to v2-dependencies-{{ checksum "yarn.lock" }} and v2-dependencies.
| "lwc": "^1.3.2", | ||
| "@lwc/wire-service": "^1.3.2", | ||
| "@lwc/compiler": "^1.11.3", | ||
| "@lwc/engine": "^1.11.3", |
There was a problem hiding this comment.
check salesforce/lwc-test#110
.circleci/config.yml
Outdated
| @@ -12,6 +12,8 @@ jobs: | |||
| - v1-dependencies-{{ checksum "yarn.lock" }} | |||
| - v1-dependencies- | |||
|
|
|||
| - run: rm -rf node_modules/ | |||
There was a problem hiding this comment.
Removing the node_modules defeats the purpose of using cache. I would instead bump the cache version to v2-dependencies-{{ checksum "yarn.lock" }} and v2-dependencies.
| "@lwc/jest-preset": "^4.5.1", | ||
| "lwc": "^1.3.2", | ||
| "@lwc/wire-service": "^1.3.2", | ||
| "@lwc/compiler": "^1.11.3", |
There was a problem hiding this comment.
If we drop support for @lwc/engine < 1.5, I would recommend adding a peer dependency restriction. This would print a warning on installation if the condition is not met.
jodarove
force-pushed
the
jodarove/upgrade-lwc-and-jest-preset
branch
from
bb83333 to
943b00d
Compare
|
LGTM, agree with PM's comment about warning via peer dependency if we drop support for @lwc/engine@1.5 |
This PR introduces a breaking change
Drops support for lwc versions < 1.5.0
Update all lwc related packages to the latest.