-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial documentation review #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
colincasey
reviewed
Mar 8, 2022
Closed
wjhsf
previously approved these changes
Apr 7, 2022
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
wjhsf
previously approved these changes
May 23, 2022
awaterma
reviewed
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one minor comment regarding expiryTime(); outside of that looks good to me!
awaterma
approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
wjhsf
approved these changes
May 24, 2022
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
…utomocks (#234) fixes #232 This PR reverts #231, #210, and #208. They provided functionality to auto mock apex methods. **Note:** Test authors will need to keep implementing their own apex (+apexContinuation) methods mocks after this PR is merged. * Revert "fix: apex automock should return a resolved promise (#231)" This reverts commit 544f95a. * Revert "fix: add apex stubs to the transformIgnorePatterns (#210)" This reverts commit fe8381a. * Revert "fix: automock apex methods with valid wire adapters (#208)" This reverts commit 125c689.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.