Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to unified versioning for all @sa11y pkgs #76

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

mohanraj-r
Copy link
Contributor

@mohanraj-r mohanraj-r commented Sep 16, 2021

Chore 🧹

  • No code changes, No breaking changes - just moving to unified versioning of @sa11y packages instead of independent versioning to reduce complexity of managing independent versions

Why

  • Due to the complexity of independently versioning the @sa11y packages, some packages were missed from version bumps in refactor: move WCAG metadata from test name to class name #74
  • Based on the experience of managing the versions of the @sa11y packages independently so far the overhead of independent versioning doesn't make much sense especially for @sa11y since most packages are not really independent from each other as much as I initially thought.
  • Switching to unified versioning going forward ..
    • Given that the highest version among @sa11y packages is v2.0.2 (@sa11y/wdio) going with v3.0.0

@mohanraj-r mohanraj-r requested review from cordeliadillon and a team as code owners September 16, 2021 19:25
@mohanraj-r mohanraj-r self-assigned this Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #76 (b9df647) into master (656e6b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          313       313           
  Branches        51        51           
=========================================
  Hits           313       313           

@mohanraj-r mohanraj-r merged commit 8432157 into master Sep 16, 2021
@mohanraj-r mohanraj-r deleted the fix_missed_version_bumps branch September 16, 2021 20:56
@mohanraj-r mohanraj-r restored the fix_missed_version_bumps branch September 16, 2021 20:56
@mohanraj-r mohanraj-r deleted the fix_missed_version_bumps branch September 16, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants