feat(engine-server): contextful wires #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divmain
requested review from
caridy,
nolanlawson,
jodarove,
ravijayaramappa and
pmdartus
divmain
commented
Nov 14, 2022
divmain
commented
Nov 14, 2022
divmain
commented
Nov 14, 2022
nolanlawson
reviewed
Nov 14, 2022
nolanlawson
reviewed
Nov 14, 2022
nolanlawson
reviewed
Nov 14, 2022
There was a problem hiding this comment.
Looks like karma tests are failing? Error: Unable to find associated VM for [object HTMLDivElement]
This LGTM, but I'm really unfamiliar with the context/wire code so I'd prefer to defer to @jodarove or another subject matter expert here.
caridy
reviewed
Nov 15, 2022
pmdartus
reviewed
Nov 15, 2022
packages/@lwc/engine-server/src/__tests__/fixtures/context-nested/wire-adapter.js
Outdated
Show resolved
Hide resolved
jodarove
reviewed
Nov 16, 2022
divmain
force-pushed
the
dbustad/context-engine-server
branch
4 times, most recently
from
7f16801 to
f7814d9
Compare
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
reviewed
Feb 17, 2023
nolanlawson
requested changes
Feb 17, 2023
divmain
force-pushed
the
dbustad/context-engine-server
branch
3 times, most recently
from
f76640c to
dd28ba7
Compare
divmain
force-pushed
the
dbustad/context-engine-server
branch
from
023c9f5 to
101e238
Compare
nolanlawson
reviewed
Feb 18, 2023
packages/@lwc/engine-server/src/__tests__/fixtures/context-no-provider/expected.html
Show resolved
Hide resolved
nolanlawson
approved these changes
Feb 18, 2023
nolanlawson
reviewed
Feb 18, 2023
divmain
force-pushed
the
dbustad/context-engine-server
branch
from
ae31fe9 to
e4686d5
Compare
divmain
force-pushed
the
dbustad/context-engine-server
branch
from
e4686d5 to
1cd0c77
Compare
|
LGTM. A minor nitpick: can we add a testcase for ensuring data is passed into slotted components? // x/test.html
<template>
<x-provider>
<x-consumer></x-consumer>
</x-provider>
</template> |
abdulsattar
approved these changes
Feb 22, 2023
pmdartus
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We have not landed on a long-term strategy for context in LWC. However, we did agree that, since contextful wires work in the browser, they should also be supported in the server. This PR adds that functionality.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?