chore: release script to create a new version and publish to npm #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
force-pushed
the
ravi/master/release-script
branch
3 times, most recently
from
3356254 to
4327428
Compare
ravijayaramappa
force-pushed
the
ravi/master/release-script
branch
from
4327428 to
1b067f4
Compare
jodarove
reviewed
Jun 16, 2020
CONTRIBUTING.md
Outdated
| ## Publishing a new release | ||
|
|
||
| Checkout the latest `master` branch of the repo. Run the `yarn release <version> <npm-tag>` command by providing the appropriate arguments to publish a new release of the package. A release commit should have been automatically created on your local branch. Push the release commit and the git tag to the remote repo. |
There was a problem hiding this comment.
should you do yarn install prior yarn release?
ravijayaramappa
force-pushed
the
ravi/master/release-script
branch
from
25f2328 to
656d9f4
Compare
ekashida
reviewed
Jun 16, 2020
CONTRIBUTING.md
Outdated
| The bigger the pull request, the longer it will take to review and merge. Try to break down large pull requests in smaller chunks that are easier to review and merge. Also make sure to reference the related issues in the pull request message if any. |
There was a problem hiding this comment.
Suggested change
| The bigger the pull request, the longer it will take to review and merge. Try to break down large pull requests in smaller chunks that are easier to review and merge. Also make sure to reference the related issues in the pull request message if any. | |
| The bigger the pull request, the longer it will take to review and merge. Try to break down large pull requests in smaller chunks that are easier to review and merge. Also make sure to reference the related issues in the pull request message, if any. |
ekashida
reviewed
Jun 16, 2020
package.json
Outdated
| @@ -7,7 +7,8 @@ | |||
| "test": "jest --config ./scripts/jest/root.config.js", | |||
| "clean": "lerna run clean && lerna clean --yes && rm -rf node_modules", | |||
| "lint": "eslint packages/ scripts/", | |||
| "format": "prettier --write '{packages,scripts}/**/*.{js,ts,json,md}'" | |||
| "format": "prettier --write '{packages,scripts}/**/*.{js,ts,json,md}'", | |||
| "release": "./scripts/release_npm.sh" | |||
There was a problem hiding this comment.
Suggested change
| "release": "./scripts/release_npm.sh" | |
| "release": "yarn install && ./scripts/release_npm.sh" |
ravijayaramappa
force-pushed
the
ravi/master/release-script
branch
from
656d9f4 to
6b219a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.