Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update peerdependency of jest to ^25.5.4 @W-7689277 #90

Merged
merged 4 commits into from
Jun 16, 2020
Merged

chore: update peerdependency of jest to ^25.5.4 @W-7689277 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfacb10
chore: update peerdependency of jest to ^25.5.4
ravijayaramappa Jun 13, 2020
b38fd4e
chore: make babel-preset-jest as a peerDependency
ravijayaramappa Jun 14, 2020
4ed55d3
chore: move babel-preset-jest to be a dependency
ravijayaramappa Jun 15, 2020
848157a
chore: update peerDependencies
ravijayaramappa Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@types/jest": "^25.2.1",
"babel-eslint": "^10.1.0",
"eslint": "^6.8.0",
"jest": "^25.5.0",
"jest": "^25.5.4",
"lerna": "^3.20.2",
"prettier": "^2.0.5"
},
Expand Down
4 changes: 0 additions & 4 deletions packages/@lwc/jest-preset/jest-preset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,4 @@ module.exports = {
// temp workaround until this is released - https://github.com/facebook/jest/pull/6792
testURL: 'http://localhost/',
coveragePathIgnorePatterns: ['.css$', '.html$'],

// Use an up-to-date version of jsdom. Jest v24 comes with jsdom v11 which doesn't offer support
// for native shadow DOM.
testEnvironment: 'jest-environment-jsdom-fifteen',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove jest-environment-jsdom-fifteen from:

  • base.config.js
  • @lwc/jest-preset/package.json

Copy link
Contributor Author

@ravijayaramappa ravijayaramappa Jun 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have been removed in the same commit 4ed55d3 as this change.

};
5 changes: 2 additions & 3 deletions packages/@lwc/jest-preset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,12 @@
"peerDependencies": {
"@lwc/compiler": "*",
"@lwc/synthetic-shadow": "*",
"jest": ">=24.9.0"
"jest": "^25.5.4"

This comment was marked as resolved.

Sign in to view

},
"dependencies": {
"@lwc/jest-resolver": "7.0.0",
"@lwc/jest-serializer": "7.0.0",
"@lwc/jest-transformer": "7.0.0",
"jest-environment-jsdom-fifteen": "^1.0.2"
"@lwc/jest-transformer": "7.0.0"
},
"engines": {
"node": ">=10"
Expand Down
6 changes: 6 additions & 0 deletions packages/@lwc/jest-resolver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,15 @@
"/resources/",
"/src/index.js"
],
"dependencies": {
"jest-resolve": "~25.5.1"
},
"devDependencies": {
"@lwc/jest-preset": "7.0.0"
},
"peerDependencies": {
"jest": "^25.5.4"
},
"license": "MIT",
"engines": {
"node": ">=10"
Expand Down
3 changes: 3 additions & 0 deletions packages/@lwc/jest-serializer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"dependencies": {
"pretty-format": "~25.4.0"
},
"peerDependencies": {
"jest": "^25.5.4"
},
"engines": {
"node": ">=10"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/@lwc/jest-transformer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
"@babel/plugin-transform-modules-commonjs": "7.9.0",
"@babel/preset-typescript": "7.9.0",
"@babel/template": "~7.8.6",
"babel-plugin-transform-dynamic-import": "^2.1.0",
"babel-preset-jest": "^25.4.0"
"babel-plugin-transform-dynamic-import": "~2.1.0",
"babel-preset-jest": "~25.5.0"
},
"peerDependencies": {
"@lwc/compiler": "*",
"jest": ">= 24.9.0"
"jest": "^25.5.4"
},
"devDependencies": {
"@lwc/jest-preset": "7.0.0",
Expand Down
4 changes: 0 additions & 4 deletions scripts/jest/base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,4 @@ module.exports = {
lines: 85,
},
},

// Use an up-to-date version of jsdom. Jest v24 comes with jsdom v11 which doesn't offer support
// for native shadow DOM.
testEnvironment: 'jest-environment-jsdom-fifteen',
};
Loading