Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: circleci npm deploy #115

Merged
merged 5 commits into from
Apr 8, 2021
Merged

chore: circleci npm deploy #115

merged 5 commits into from
Apr 8, 2021

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Apr 5, 2021

Deploy npm packages using circleci

@ekashida ekashida force-pushed the ekashida/circleci-deploy branch 2 times, most recently from 6e3eaed to 8d57618 Compare April 5, 2021 15:06
@ekashida ekashida force-pushed the ekashida/circleci-deploy branch from 8d57618 to 08b5782 Compare April 8, 2021 10:39
docker:
- image: circleci/node:lts
working_directory: ~/repo
- image: circleci/node:14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circleci best practice is to use an exact version number so this is probably a good middle ground.

@ekashida ekashida marked this pull request as ready for review April 8, 2021 10:42
@ekashida ekashida merged commit a922687 into master Apr 8, 2021
@ekashida ekashida deleted the ekashida/circleci-deploy branch April 8, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant