Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowList option to no-disallowed-lwc-imports #97

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Add allowList option to no-disallowed-lwc-imports #97

merged 2 commits into from
Jun 30, 2022

Conversation

pmdartus
Copy link
Member

This PR introduces the new allowList option to the no-disallowed-lwc-imports rule. When set this option overrides the default list of available APIs on lwc.

Misc:

  • Updated the error message to be more generic.

nolanlawson
nolanlawson requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about spelling, but LGTM overall

docs/rules/no-disallowed-lwc-imports.md Outdated Show resolved Hide resolved
@pmdartus pmdartus merged commit 8a7a4e8 into master Jun 30, 2022
@pmdartus pmdartus deleted the pmdartus/api-allowlist branch June 30, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanlawson nolanlawson nolanlawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmdartus @nolanlawson