feat!: update dependency to eslint v9 @W-17448473 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Jan 3, 2025
.circleci/config.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| version: 2.1 | |||
|
|
|||
| supported-eslint-versions: &supported-eslint-versions ['local', '7'] | |||
| supported-eslint-versions: &supported-eslint-versions ['local', '9'] | |||
There was a problem hiding this comment.
We do not need this logic anymore. We can just use the local ESLint version, since it's assumed to be v9.
ravijayaramappa
force-pushed
the
ravi/eslint-v9/update-eslint-dep
branch
3 times, most recently
from
08d2e1c to
7f64827
Compare
wjhsf
approved these changes
Jan 7, 2025
README.md
Outdated
| @@ -12,70 +12,99 @@ Note that `@lwc/eslint-plugin-lwc`, `@salesforce/eslint-plugin-lightning`, `esli | |||
|
|
|||
| ## Usage | |||
|
|
|||
| Add the appropriate [configuration](#Configurations) to the `extends` field in your configuration. | |||
| _Starting with v4.0.0, @salesforce/eslint-config-lwc only supports eslint@v9. Use @salesforce/eslint-config-lwc@v3.x for older versions of eslint._ | |||
There was a problem hiding this comment.
Suggested change
| _Starting with v4.0.0, @salesforce/eslint-config-lwc only supports eslint@v9. Use @salesforce/eslint-config-lwc@v3.x for older versions of eslint._ | |
| >[!IMPORTANT] | |
| > Starting with v4.0.0, @salesforce/eslint-config-lwc only supports eslint v9. Use @salesforce/eslint-config-lwc v3 for older versions of eslint. |
With the @ as written, it renders as an email link. 😕
Starting with v4.0.0, @salesforce/eslint-config-lwc only supports eslint@v9. Use @salesforce/eslint-config-lwc@v3.x for older versions of eslint.
BREAKING CHANGE: dropping support for ESLint v7 and v8. The only supported option is ESLint v9
ravijayaramappa
force-pushed
the
ravi/eslint-v9/update-eslint-dep
branch
from
0396917 to
80c4d7c
Compare
ravijayaramappa
force-pushed
the
ravi/eslint-v9/update-eslint-dep
branch
from
80c4d7c to
073f2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: dropping support for ESLint v7 and v8. The only supported option is ESLint v9
Fixes #128
Depends on salesforce/eslint-plugin-lightning#14