Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew scripts #218

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Fix homebrew scripts #218

merged 2 commits into from
Aug 16, 2021

Conversation

kmcquade
Copy link
Collaborator

What does this PR do?

The Homebrew automation was broken, mostly due to a race condition where the sleep interval wasn't long enough to wait for PyPi servers to have the new Cloudsplaining version.

Completion checklist

  • Additions and changes have unit tests
  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)
  • If the UI contents or JavaScript files have been modified, generate a new example report:
# Generate the updated Javascript bundle
make build-js

# Generate the example report
make generate-report

@kmcquade kmcquade merged commit 0eee035 into master Aug 16, 2021
@kmcquade kmcquade deleted the fix/homebrew-scripts branch August 16, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant