-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan Multiple AWS accounts via AssumeRole #172
Merged
kmcquade
merged 10 commits into
salesforce:master
from
kmcquade:feat/scan-accounts-command
Apr 7, 2021
Merged
Scan Multiple AWS accounts via AssumeRole #172
kmcquade
merged 10 commits into
salesforce:master
from
kmcquade:feat/scan-accounts-command
Apr 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegorski
reviewed
Mar 28, 2021
yegorski
reviewed
Mar 29, 2021
@yegorski - due to lots of demand, having tested this myself, and having addressed your previous suggestions I am going to go ahead and merge this PR and bump the version to 0.4.0. I've updated the documentation to include instructions on scanning as well. If you run into any issues, let me know. And feel free to open a new GitHub issue. |
@kmcquade sounds great, thank you! Can't wait to use it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scan_account
method that can be used for Lambda deployments (related to Deployment through lambda? #39)What gif best describes this PR or how it makes you feel?
Completion checklist
npm test
)npm build
andpython3 ./utils/generate_example_report.py
)